Docker stderr #23
Docker stderr #23
Conversation
|
I did something wrong here. I don't know why it's showing all these other commits. |
|
Changes look good. The reason why the other commits were showing is cause the target branch was 1.9, but the latest is 1.12. I have fixed that and now the commits are as expected. I'll merge this when the other plugins have this change as well :) |
| @@ -129,7 +129,7 @@ public void setName(String name) { | |||
| @Override | |||
| public void doAppend(ILoggingEvent event) throws LogbackException { | |||
| if (event.getLevel() == Level.ERROR) { | |||
| Logging.error(start, event.getFormattedMessage(), false); | |||
| Logging.error(start, event.getFormattedMessage(), true); | |||
There was a problem hiding this comment.
Do you know what kind of error logs are sent by Hikari and how often?
There was a problem hiding this comment.
Here are the logged errors I found in HikariCP:
"Property {} does not exist on target {}"
"{} - JMX name ({}) is already registered."
"{} - Failed to execute{} connection test query ({})."
"Failed to load driver class {} from HikariConfig class classloader {}"
"{} - Error thrown while acquiring connection from data source"
They appear to be entirely configuration and connection errors, so I wouldn't expect them to appear often.
There was a problem hiding this comment.
I see. Alright then! This seems fine for now. I'll investigate this a bit more though.
Summary of change
When running in a container without
$ERROR_LOG_PATHspecified, this change will now print errors tostderr.Related issues
Test Plan
sudo docker run --network="host" -p 3567:3567 -v $HOME/Development/supertokens/docker-logs:/home/logs -e MYSQL_HOST="127.0.0.1" -e MYSQL_PORT="3307" -e INFO_LOG_PATH="/home/logs/info.log" supertokens 2> >(while read line; do echo -e "\e[01;31m$line\e[0m" >&2; done)Documentation changes
None
Checklist for important updates
pluginInterfaceSupported.jsonfile has been updated (if needed)build.gradlebuild.gradle, please make sure to add them inimplementationDependencies.json.git tag) in the formatvX.Y.Z, and then find the latest branch (git branch --all) whoseX.Yis greater than the latest released tag.Remaining TODOs for this PR
None