remove zIndex property #4685
remove zIndex property #4685
Conversation
| triggerSelector="#marked-for-desks" | ||
| title={gettext('Marked for')} | ||
| title={gettext('Marked for 123123123')} |
|
did you expose a function from ui-framework to get latest z-index when not using ui-framework components? |
|
but i dont need it for this pr... |
|
How likely it is that someone will need it later? Probably 100% :D Do expose it now(from ui-framework side) so others don't need to later. |
|
but this is ui framework side... i just need to export it.. why is that in relationship with this pr? |
|
do i need to bump version of ui framework again after exporting? |
|
fix ci |
|
@dzonidoo I've restarted unit tests, they do pass now, but there are issues with extensions - do take a look |
|
@tomaskikutis so do i need to reset the failed test? |
|
no, you need to fix the issues with extensions - see logs |
|
there are also some z-indexes in angular templates like here, should those be removed too? seems like it's causing some issues currently |
|
The reason why z-indexes were removed from react components is because we are handling z-indexes on ui-framework side. That only happens for react components though. I think there are 2 options here @dzonidoo, either to initialize z-index on ui-framework side to a lower value so it doesn't conflict with angular z-indexes, or export that function from ui-framework to generate a next z-index and use it for angular components. |
SDESK-7429