Cosmetic metadata widget changes, persist changes on full width toggl… #4667
Conversation
…ing, fix authors field, fix dropdown field
|
Could you post a screenshot with profile selection? |
Yes, here it is. Unopened: Opened: |
scripts/core/superdesk-api.d.ts
Outdated
| secondaryToolbarWidgets: Array<React.ComponentType<{item: T}>>; | ||
| secondaryToolbarWidgets: Array<React.ComponentType<{ | ||
| item: T; | ||
| onChange(itemWithChanges: T): void; |
There was a problem hiding this comment.
Would this "onChange" actually reinitialize? If so I think we should call it "reinitialize" so it is clear that it will be performance intensive and can't be called on every key press.
|
Can you revert the latest commit and prepare the branch to be merged? Let's do widget persistance in another PR |
…pin" This reverts commit 375fb94.
|
Showcase of how the reworked toolbar style looks 
Authoring itself becomes scrollable, toolbar included. |
|
What needs to be decided is if we should have a third toolbar. In authoring angular this is how the view currently looks (and it is as a part of the heather fields): |
|
only use Replace classname soup(className="flex flex-row flex-wrap align-center px-2 gap-1 py-1") with inline styles or a single classname. Regarding the third toolbar - let's not have it. It doesn't show anything that is not already displayed elsewhere. In the long run we'll probably make it more customizable so it would be possible to set up any number of toolbars from root repo. |
What's the difference? Only style of how we write CSS? And if we change our spacing at some point, that wouldn't be reflected. |
Easier to work with. Why spend time on coming up and remembering class names when we can use standard CSS rules directly. For spacing and other things - use variables. |
|
I've made it look the same as in Angular, after talking to fritz: |
| @@ -1491,26 +1503,43 @@ export class AuthoringReact<T extends IBaseRestApiResponse> extends React.PureCo | |||
| </ButtonGroup> | |||
| </div> | |||
| )} | |||
| headerStyles='authoring-header--padding-medium pt-1' | |||
There was a problem hiding this comment.
do not use CSS classnames coming outside of this project. Address other occurences of the same in this PR too.
scripts/apps/authoring-react/subcomponents/content-profile-dropdown.tsx
Outdated
Show resolved
Hide resolved
scripts/apps/authoring-react/subcomponents/content-profile-dropdown.tsx
Outdated
Show resolved
Hide resolved
scripts/apps/authoring-react/subcomponents/content-profile-dropdown.tsx
Outdated
Show resolved
Hide resolved
| @@ -1502,7 +1502,7 @@ export class AuthoringReact<T extends IBaseRestApiResponse> extends React.PureCo | |||
| </ButtonGroup> | |||
| </div> | |||
| )} | |||
| headerStyles="authoring-header--padding-medium pt-1" | |||
| headerPadding={{top: 8}} | |||
There was a problem hiding this comment.
should have been paddingBlockStart
|
Hey, I missed an important issue here. I though you were doing a profile selector via angular wrapper thing. You can't put it inside authoring-react.ts, because authoring-react is generic. You don't know if it's an article or some other entity you're dealing with. The compiler was warning you 😄 |
|
Move the usage from authoring-react and pass it through the api or |
SDESK-7341
SDESK-7417
SDESK-7340