remove toggle button theme from header #4312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -44,7 +44,7 @@ export function UserPreferencesDirective( | |||
| const body = angular.element('body'); | |||
|
|
|||
| scope.activeNavigation = null; | |||
| scope.activeTheme = localStorage.getItem('theme'); | |||
| scope.activeTheme = localStorage.getItem('theme') !== '' ? localStorage.getItem('theme') : 'light-ui'; | |||
There was a problem hiding this comment.
It's not ideal to read local storage twice. I'd be nicer to do it like this:
scope.activeTheme = localStorage.getItem('theme');
if (scope.activeTheme === '') {
scope.activeTheme = 'light-ui';
}
It would also be better to use a constant instead of inlining light-ui.
|
can you use a constant? :) |
| @@ -4,6 +4,8 @@ import {gettext} from 'core/utils'; | |||
| import {appConfig, getUserInterfaceLanguage} from 'appConfig'; | |||
| import {applyDefault} from 'core/helpers/typescript-helpers'; | |||
|
|
|||
| const theme = 'light-ui'; | |||
There was a problem hiding this comment.
use capital letters for a variable name - THEME_LIGHT
tomaskikutis
requested changes
Sep 13, 2023
tomaskikutis
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDESK-7037