part II - remove component from this repo and use the one from ui fra…

…mework

scripts/apps/authoring-react/authoring-angular-integration.tsx

@@ -3,7 +3,7 @@
 import {assertNever} from 'core/helpers/typescript-helpers';
 import {DeskAndStage} from './subcomponents/desk-and-stage';
 import {LockInfo} from './subcomponents/lock-info';
-import {Button, ButtonGroup, IconButton, Label, Modal, NavButton, Popover, Spacer} from 'superdesk-ui-framework/react';
+import {Button, ButtonGroup, IconButton, Label, Modal, NavButton, Popover, Spacer, WithPopover} from 'superdesk-ui-framework/react';
 import {
     IArticle,
     ITopBarWidget,
@@ -19,7 +19,6 @@ import {sdApi} from 'api';
 import ng from 'core/services/ng';
 import {AuthoringIntegrationWrapper} from './authoring-integration-wrapper';
 import {MarkedDesks} from './toolbar/mark-for-desks/mark-for-desks-popover';
-import {WithPopover} from 'core/helpers/with-popover';
 import {HighlightsCardContent} from './toolbar/highlights-management';
 import {
     authoringStorageIArticle,
@@ -168,7 +167,6 @@ function getInlineToolbarActions(
                     />
                 )}
                 placement="right-end"
-                zIndex={1050}
             >
                 {
                     (togglePopup) => (

scripts/apps/search/components/fields/translations.tsx

@@ -2,7 +2,7 @@ import React from 'react';
 import {gettext, gettextPlural} from 'core/utils';
 import {IArticle} from 'superdesk-api';
 import {TranslationsListWrapper} from '../translations-list-wrapper';
-import {showPopup} from 'core/ui/components/popupNew';
+import {showPopup} from 'superdesk-ui-framework/react';
 
 interface IProps {
     item: IArticle;
@@ -41,7 +41,6 @@ export class Translations extends React.PureComponent<IProps> {
                     close={closePopup}
                 />
             ),
-            100,
         );
     }
 

scripts/core/editor3/components/annotations/AnnotationInput.tsx

@@ -298,7 +298,6 @@ class AnnotationInputBody extends React.Component<IProps, IState> {
                 ref={(component) => {
                     this.positionerRef = component;
                 }}
-                zIndex={1051}
             >
                 <Card padding={10}>
                     <div className="annotation-input" style={{width: 460}}>

scripts/core/get-superdesk-api-implementation.tsx

@@ -109,7 +109,6 @@ import {
     LockInfo,
 } from 'apps/authoring-react/subcomponents/lock-info-generic';
 import {tryLocking, tryUnlocking} from './helpers/locking-helpers';
-import {showPopup} from './ui/components/popupNew';
 import {Card} from './ui/components/Card';
 import {getTextColor} from './helpers/utils';
 import {showModal} from '@superdesk/common';
@@ -120,6 +119,7 @@ import {getLabelNameResolver} from 'apps/workspace/helpers/getLabelForFieldId';
 import {getSortedFields, getSortedFieldsFiltered} from 'apps/authoring/preview/utils';
 import {editor3ToOperationalFormat} from 'apps/authoring-react/fields/editor3';
 import {prepareSuperdeskQuery} from './helpers/universal-query';
+import {showPopup} from 'superdesk-ui-framework/react';
 
 export function openArticle(
     id: IArticle['_id'],

scripts/core/superdesk-api.d.ts

@@ -3081,7 +3081,6 @@ declare module 'superdesk-api' {
                 referenceElement: HTMLElement,
                 placement: import('@popperjs/core').Placement,
                 Component: React.ComponentType<{closePopup(): void}>,
-                zIndex?: number,
                 closeOnHoverEnd?: boolean,
                 onClose?: () => void,
             ): {close: () => void};

scripts/core/ui/components/UserPopup/UserPopup.tsx

@@ -1,8 +1,8 @@
 import React from 'react';
-import {showPopup} from 'core/ui/components/popupNew';
 import {IUser} from 'superdesk-api';
 import {UserAvatar} from 'apps/users/components/UserAvatar';
 import {gettext} from 'core/utils';
+import {showPopup} from 'superdesk-ui-framework/react';
 
 interface IProps {
     user: IUser;
@@ -28,7 +28,6 @@ const UserPopup = ({mentionName, user}: IProps) => {
                     </div>
                 </div>
             ),
-            100,
             true,
         );
     };

scripts/core/ui/components/content-create-dropdown/content-create-dropdown.tsx

@@ -2,10 +2,9 @@
 
 import React from 'react';
 import {IArticle} from 'superdesk-api';
-import {Button} from 'superdesk-ui-framework/react';
+import {Button, showPopup} from 'superdesk-ui-framework/react';
 import ng from 'core/services/ng';
 import {gettext} from 'core/utils';
-import {showPopup} from '../popupNew';
 import {InitialView} from './initial-view';
 import {DropZone3} from '../drop-zone-3';
 import {getSuperdeskType} from 'utils/dragging';
@@ -78,7 +77,6 @@ export class ContentCreateDropdown extends React.PureComponent<IProps> {
                                     onCreate={this.props.onCreate}
                                 />
                             ),
-                            1050,
                         );
                     }}
                 />

scripts/core/ui/components/position-once.tsx

@@ -1,9 +1,13 @@
+import {Placement} from '@popperjs/core';
 import React from 'react';
 import ReactDOM from 'react-dom';
-import {IPropsPositioner, PopupPositioner} from './popupNew';
+import {PopupPositioner} from 'superdesk-ui-framework/react';
 
-interface IProps extends Omit<IPropsPositioner, 'referenceElement'> {
+interface IProps {
     delayed?: boolean;
+    placement: Placement;
+    onClose(): void;
+    closeOnHoverEnd?: boolean;
 }
 
 interface IState {
@@ -41,7 +45,6 @@ export class PositionInline extends React.PureComponent<IProps, IState> {
                         <PopupPositioner
                             referenceElement={this.referenceEl}
                             placement={this.props.placement}
-                            zIndex={this.props.zIndex}
                             onClose={this.props.onClose}
                         >
                             {this.props.children}

scripts/core/ui/components/virtual-lists/select.tsx

@@ -1,12 +1,11 @@
 import React from 'react';
 import {SuperdeskReactComponent} from 'core/SuperdeskReactComponent';
-import {showPopup} from '../popupNew';
 import {IBaseRestApiResponse, IPropsSelectFromRemote, ISuperdeskQuery} from 'superdesk-api';
 import {VirtualListFromQuery} from './virtual-list-from-query';
 import {gettext} from 'core/utils';
 import {InputLabel} from '../input-label';
 import {SpacerBlock} from '../Spacer';
-import {IconButton} from 'superdesk-ui-framework';
+import {IconButton, showPopup} from 'superdesk-ui-framework/react';
 
 interface IState<T> {
     selected: 'loading' | T | null;
@@ -154,7 +153,6 @@ export class SelectFromEndpoint<T extends IBaseRestApiResponse>
                                     />
                                 </div>
                             ),
-                            3000,
                             undefined,
                             () => {
                                 this.lastPopup = null;