Merge branch 'broadcasting' into authoring-react-post-broadcasting

superdesk · Sep 11, 2023 · 34863b1 · 34863b1
2 parents f2d5cf1 + b3f054b
commit 34863b1
Show file tree

Hide file tree

Showing 25 changed files with 334 additions and 139 deletions.
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -62,3 +62,8 @@ jobs:
       with:
         name: screenshots-e2e-${{ matrix.suite }}
         path: /tmp/*.png
+
+    - name: Server Logs
+      if: ${{ failure() }}
+      run: docker-compose logs superdesk
+      working-directory: e2e/server
diff --git a/e2e/client/package.json b/e2e/client/package.json
@@ -12,7 +12,7 @@
     "jasmine-reporters": "2.3.0",
     "protractor": "7.0.0",
     "typescript": "4.9.3",
-    "webdriver-manager": "^12.1.8"
+    "webdriver-manager": "^12.1.9"
   },
   "scripts": {
     "build": "npx @superdesk/build-tools build-root-repo ./",

diff --git a/e2e/client/protractor.conf.js b/e2e/client/protractor.conf.js
@@ -1,6 +1,7 @@
 /* eslint-disable comma-dangle */
 
 var path = require('path');
+const execSync = require('child_process').execSync;
 
 function getChromeOptions() {
     var chromeOptions = {
@@ -55,6 +56,16 @@ var config = {
     chromeDriver: process.env.CHROMEWEBDRIVER ? (process.env.CHROMEWEBDRIVER + '/chromedriver') : null,
 
     onPrepare: function() {
+        execSync(
+            `
+                echo "chrome version:" && $CHROME_BIN --version
+                echo "\n"
+                echo "webdriver-manager version:" && npx webdriver-manager version
+                echo "\n"
+            `,
+            {stdio: 'inherit'},
+        );
+
         require('./specs/helpers/setup').setup({fixture_profile: 'app_prepopulate_data'});
 
         // so it can be used without import in tests
@@ -73,6 +84,7 @@ var config = {
             this.specDone = function(result) {
                 if (result.failedExpectations.length > 0) {
                     browser.screenshot(result.fullName.replace(/[^\w]+/g, '-'));
+                    require('./specs/helpers/utils').printLogs();
                 }
             };
         }

diff --git a/e2e/client/run-end-to-end-tests.js b/e2e/client/run-end-to-end-tests.js
@@ -19,7 +19,7 @@ function installWebdriverDriver() {
         } catch (_) {
             // driver not installed, installing:
 
-            const  version = execSync('$CHROME_BIN --product-version').toString();;
+            const  version = execSync('$CHROME_BIN --product-version').toString();
 
             if (version == null) {
                 return reject('To launch the test server a chrome based browser has to be installed and CHROME_BIN environment variable set.');
@@ -38,7 +38,7 @@ ensurePackageInstalled()
     .then(() => {
         const argumentsToForward = process.argv.slice(2).join(' ');
 
-        return execSync(`npx protractor protractor.conf.js ${argumentsToForward}`, {stdio: 'inherit'});
+        execSync(`npx protractor protractor.conf.js ${argumentsToForward}`, {stdio: 'inherit'});
     })
     .catch((e) => {
         console.error(e);

diff --git a/e2e/client/specs/helpers/utils.ts b/e2e/client/specs/helpers/utils.ts
@@ -42,10 +42,9 @@ export function printLogs(prefix) {
         .then((browserLog) => {
             var logs = browserLog.filter((log) => log.level.value >= 1000);
 
-            console.info(
-                (prefix ? prefix + ' ' : '') +
-                'log: ' + require('util').inspect(logs, {dept: 3}),
-            );
+            for (const log of logs) {
+                console.error(`BROWSER CONSOLE ERROR: ${log.message}`);
+            }
         });
 }
 

diff --git a/e2e/server/Procfile b/e2e/server/Procfile
@@ -1,2 +1,3 @@
 rest: PYTHONUNBUFFERED=True gunicorn -c gunicorn_config.py wsgi
 wamp: python3 -u ws.py
+work: celery -A worker worker
diff --git a/e2e/server/docker-compose.yml b/e2e/server/docker-compose.yml
@@ -24,6 +24,7 @@ services:
             - e2e
         environment:
             - discovery.type=single-node
+            - action.auto_create_index=false
         tmpfs:
             - /usr/share/elasticsearch/data
 

diff --git a/e2e/server/settings.py b/e2e/server/settings.py
@@ -1,7 +1,7 @@
 
 import os
 
-DEBUG = bool(os.environ.get('SUPERDESK_DEBUG'))
+DEBUG = False
 SUPERDESK_TESTING = True
 
 SERVER_NAME = 'localhost:5000'
@@ -25,6 +25,6 @@
 CONTENTAPI_ELASTICSEARCH_INDEX = CONTENTAPI_MONGO_DBNAME
 
 LEGAL_ARCHIVE = True
-CELERY_TASK_ALWAYS_EAGER = True
+CELERY_TASK_ALWAYS_EAGER = False
 
 DEFAULT_TIMEZONE = "Europe/London"