[WIP] Updated plug. Refactor Router/Controller. #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #54. first part of a major refactor in order to allow sugar to track plug's latest versions easier. leveraging the placid way of handling routers and controllers (handlers) so that they are more plug-oriented and can use plugs in a more idiomatic way.
strip out hooks and filters in favor of plugs. plug stack in controllers allows for before/after functionality, but router stack doesn't. not sure that it needs it. add functionality/tests for matched controller/action in conn.private. improved test coverage.
fix copy_req_content_type router plug. add HttpsOnly and XML parser
slogsdon
added a commit
that referenced
this pull request
Dec 24, 2014
Updated plug. Refactor Router/Controller.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #54.
First part of a major refactor in order to allow Sugar to track Plug's latest versions easier. Leveraging the Placid way of handling Routers and Handlers (Controllers) so that they are more Plug-oriented and can use plugs in a more idiomatic way.
Remaining bits include ensuring older functionality continues (even if under a different name), including hooks and filters (which both should be good to go with the internal Plug stacks brought over from Placid's implementations).
When complete, this should easily pave the way for the completion of #16, #17, #41, and #55.
Comments welcome and encouraged.