Update nepali-date-helper.ts for year 2082 BS #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The days in the dates were referenced from: https://www.bolpatra.gov.np/egp/openDateConverter
|
Hey @joonshakya, Thanks for raising this PR! I had a look at other sources, hamro patra and they seem to have different dates. This is always the case every year. I haven't yet been able to pick the source of truth for the dataset. Would you be able to check other sources to see if they align with yours too? Also, would you be able to rebase your changes from master after you verify? I made some improvements and now you need to update here Baisakh
Jestha
Asar
Shrawan
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The days in the dates were referenced from: https://www.bolpatra.gov.np/egp/openDateConverter