Create classes feedback motivation page #314
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -122,6 +122,7 @@ | |||||
| "actionOpenFilter": "Open filter", | ||||||
| "actionRequestPermissions": "Request permissions", | ||||||
| "actionRefresh": "Refresh", | ||||||
| "actionLearnMore": "Learn more", | ||||||
|
|
||||||
| "errorSomethingWentWrong": "Something went wrong.", | ||||||
| "errorPasswordsDiffer": "The two passwords differ.", | ||||||
|
|
@@ -201,6 +202,7 @@ | |||||
| "navigationClassFeedback": "Feedback", | ||||||
| "navigationClassesFeedbackChecklist": "Feedback checklist", | ||||||
| "navigationAdmin": "Permission requests", | ||||||
| "navigationFeedbackMotivation": "Motivation", | ||||||
|
|
||||||
| "filterMenuShowAll": "Show all", | ||||||
| "filterMenuShowMine": "Show only mine", | ||||||
|
|
@@ -305,6 +307,13 @@ | |||||
| "messageAlreadySeeingCurrentWeek": "You're already seeing the current week!", | ||||||
| "messageReportSent": "Report sent successfully.", | ||||||
| "messageReportNotSent": "Report could not be sent.", | ||||||
| "messageFeedbackMotivationOverview": "Share your experience so future generations of students will receive statistics about this class!", | ||||||
| "messageFeedbackAspects": "Key aspects we take into account:", | ||||||
| "messageFeedbackMotivation1": "Your data and privacy are respected. We do not report individual responses, but these are aggregated, thus an opinion cannot be associated with a particular profile.", | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
| "messageFeedbackMotivation2": "Information shared will be kept in our database for at least 4 years (study duration of a Bachelor's degree), so the evolution over time can be observed.", | ||||||
| "messageFeedbackMotivation3": "Access to statistics is allowed to any student who wants to find out impressions about a class during the semester. However, while the opportunity to share your feedback is active, only students who have already expressed their opinion can analyze the ideas of others.", | ||||||
|
There was a problem hiding this comment. much word, few meaning
Suggested change
There was a problem hiding this comment. But to the actual meaning of this, I see some issues:
|
||||||
| "messageFeedbackMotivation4": "The whole process of collecting and displaying reviews is transparent. Being an open-source application, source code is accessible to everyone.", | ||||||
|
There was a problem hiding this comment. A link to the repo would make sense here. You have a few options for styling a link:
|
||||||
| "messageFeedbackMotivation5": "We are constantly looking to improve the connection between different generations of students. As a result, any thought is extremely valuable. All the details supplied are used pro-actively.", | ||||||
|
There was a problem hiding this comment. I don't think proactive means what you think it means (and also, it's one word). I'd remove this entire part, I don't see the purpose. |
||||||
|
|
||||||
| "infoPasswordResetEmailSent": "Please check your inbox for the password reset e-mail.", | ||||||
| "infoRelevance": "Try to choose the most restrictive category.", | ||||||
|
|
||||||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| import 'package:firebase_remote_config/firebase_remote_config.dart'; | ||
|
|
||
| const String _feedbackEnabled = 'feedback_enabled'; | ||
|
|
||
| class RemoteConfigService { | ||
| RemoteConfigService({RemoteConfig remoteConfig}) | ||
| : _remoteConfig = remoteConfig; | ||
| final RemoteConfig _remoteConfig; | ||
| final defaults = <String, dynamic>{_feedbackEnabled: false}; | ||
| static RemoteConfigService _instance; | ||
|
|
||
| static Future<RemoteConfigService> getInstance() async { | ||
| return _instance ??= RemoteConfigService( | ||
| remoteConfig: await RemoteConfig.instance, | ||
| ); | ||
| } | ||
|
|
||
| bool get feedbackEnabled => | ||
| // ignore: avoid_bool_literals_in_conditional_expressions | ||
| _remoteConfig == null ? true : _remoteConfig.getBool(_feedbackEnabled); | ||
|
|
||
| Future<dynamic> initialise() async { | ||
| try { | ||
| await _remoteConfig.setDefaults(defaults); | ||
| await _fetchAndActivate(); | ||
| } on FetchThrottledException catch (e) { | ||
| print('Remote config fetch throttled: $e'); | ||
| } catch (e) { | ||
| print( | ||
| 'Unable to fetch remote config. Cached or default values will be used.'); | ||
| } | ||
| } | ||
|
|
||
| Future<dynamic> _fetchAndActivate() async { | ||
| await _remoteConfig.fetch(); | ||
| await _remoteConfig.activateFetched(); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,6 +3,7 @@ import 'package:acs_upb_mobile/generated/l10n.dart'; | |
| import 'package:acs_upb_mobile/pages/class_feedback/model/questions/question.dart'; | ||
| import 'package:acs_upb_mobile/pages/class_feedback/service/feedback_provider.dart'; | ||
| import 'package:acs_upb_mobile/pages/class_feedback/view/feedback_question.dart'; | ||
| import 'package:acs_upb_mobile/pages/class_feedback/view/feedback_motivation.dart'; | ||
| import 'package:acs_upb_mobile/pages/classes/model/class.dart'; | ||
| import 'package:acs_upb_mobile/pages/people/model/person.dart'; | ||
| import 'package:acs_upb_mobile/pages/people/service/person_provider.dart'; | ||
|
|
@@ -213,7 +214,14 @@ class _ClassFeedbackViewState extends State<ClassFeedbackView> { | |
| child: IconText( | ||
| icon: Icons.info_outline, | ||
| text: S.current.infoFormAnonymous, | ||
| actionText: S.current.actionLearnMore, | ||
| actionArrow: true, | ||
| style: Theme.of(context).textTheme.bodyText1, | ||
| onTap: () => Navigator.of(context).push( | ||
| MaterialPageRoute<FeedbackMotivation>( | ||
| builder: (_) => FeedbackMotivation(), | ||
| ), | ||
| ), | ||
| ), | ||
| ), | ||
| ), | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.