Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Monorepo root dependencies as devDependencies #2911

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

teogeb
Copy link
Contributor

@teogeb teogeb commented Nov 25, 2024

Changed root package.json dependencies to devDependencies. It doesn't change any functionality, but allows us to upgrade @manypkg/cli (i.e. unblocks #2909).

The change suggested by @manypkg/cli makes the dependency setup more consistent. See more detailed explanation here: https://github.com/Thinkmill/manypkg?tab=readme-ov-file#root-has-prod-dependencies.

  • it would be also possible to add ROOT_HAS_PROD_DEPENDENCIES to manypkg's ignoredRules if we prefer not to do this change

Other changes

Also updated @manypkg/cli to latest.

@teogeb teogeb merged commit dd6ad65 into main Nov 26, 2024
24 checks passed
@teogeb teogeb deleted the monorepo-root-dependencies branch November 26, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants