-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge current most-up-to-date-livestreamer into streamlink #9
Merge current most-up-to-date-livestreamer into streamlink #9
Conversation
… to find the stream URLs needed to be updated.
Fixed flaws according to chrippa/livestreamer#936
…he url extensions is mp3
341bc38
to
2b51da5
Compare
This reverts commit d6bff6d. Reverted to avoid conflict with next pull.
…on a bytes-like object")
…, not 'str'"). Also remove debug output.
Hey @LoneFox78 Thanks so much for all the hard work! Mind giving this your grace and we could merge this in? :) This would be a great base to start our fork / dev on streamlink with all the most up-to-date PR's. |
Did anyone confirm all of these work on a fresh build? |
@gravyboat I did check a random stream for each site. There was one that didn't work (afreecatv.jp) and a few that I couldn't test beacuse of geo restrictions. Also, this was with python 3.5.2, and it is possible that there are problems with older versions of python. |
May as well have this merged in so we have a good base. Did anyone else check some of the major ones (twitch, livestream, etc.)? |
Twitch works fine. So does ustream (only tried the hls stream). For livestream.com (using the akaimhd stream) I get |
@cdrage chrippa/livestreamer#1461 - "goodgame.ru" works fine. |
I say that we merge this PR as-is so we're the most up-to-date with everything and start working through all the plugins. I'm going to try and find some spare time later today to start converting the naming scheme from livestreamer to streamlink within the code and get a good "base release" for streamlink. EDIT: To be honest, it's fine to be a bit "messy" right now with these early commits as we move towards a cleaning / refactoring of the code. We can be a bit more stringent later as we move towards a more production-level code-base. |
There is a fix checked into livestreamer for the livestream.com issue. If nobody else has fixed it, I might try to merge it in later. From: skulblakka notifications@github.com Twitch works fine. So does ustream (only tried the hls stream). For livestream.com (using the akaimhd stream) I get 404 Client Error: Not Found for url: http://viewerplus.livestream.com/assets/swf/hdplayer-2.0-viewerplus.swf. The hls one works. You are receiving this because you are subscribed to this thread. |
@cdrage I'm fine with merging this in and agree with your point regarding it being messy. My main concern is that the primary sites still worked. As such I'm going to merge this. Edit. I should note I did NOT squash on purpose so we can keep the history and properly credit these users. |
@gravyboat I opened a PR to fix azubu.tv |
@brainzyy I saw it, I'm going to have to let someone else review it for the time being as I'm not familiar enough with the codebase yet to review it confidently. |
@gravyboat thanks for the merge! Alright. Now it's time to clean-up some of the code! xD I should have a few hours this week to contribute. |
No description provided.