Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge current most-up-to-date-livestreamer into streamlink #9

Merged
merged 144 commits into from
Sep 19, 2016

Conversation

cdrage
Copy link
Contributor

@cdrage cdrage commented Sep 18, 2016

No description provided.

@cdrage cdrage changed the title Bump version to 1.14.0-rc1 Merge current most-up-to-date-livestreamer into streamlink Sep 18, 2016
betagan and others added 29 commits September 18, 2016 15:25
… to find the stream URLs needed to be updated.
@cdrage
Copy link
Contributor Author

cdrage commented Sep 18, 2016

Hey @LoneFox78

Thanks so much for all the hard work!

Mind giving this your grace and we could merge this in? :)

This would be a great base to start our fork / dev on streamlink with all the most up-to-date PR's.

@gravyboat
Copy link
Member

Did anyone confirm all of these work on a fresh build?

@LoneFox78
Copy link
Contributor

@gravyboat I did check a random stream for each site. There was one that didn't work (afreecatv.jp) and a few that I couldn't test beacuse of geo restrictions. Also, this was with python 3.5.2, and it is possible that there are problems with older versions of python.

@cdrage
Copy link
Contributor Author

cdrage commented Sep 19, 2016

May as well have this merged in so we have a good base.

Did anyone else check some of the major ones (twitch, livestream, etc.)?

@skulblakka
Copy link
Contributor

Twitch works fine. So does ustream (only tried the hls stream).

For livestream.com (using the akaimhd stream) I get 404 Client Error: Not Found for url: http://viewerplus.livestream.com/assets/swf/hdplayer-2.0-viewerplus.swf. The hls one works.

@flijloku
Copy link

@cdrage chrippa/livestreamer#1461 - "goodgame.ru" works fine.

@cdrage
Copy link
Contributor Author

cdrage commented Sep 19, 2016

I say that we merge this PR as-is so we're the most up-to-date with everything and start working through all the plugins.

I'm going to try and find some spare time later today to start converting the naming scheme from livestreamer to streamlink within the code and get a good "base release" for streamlink.

EDIT: To be honest, it's fine to be a bit "messy" right now with these early commits as we move towards a cleaning / refactoring of the code. We can be a bit more stringent later as we move towards a more production-level code-base.

@scottbernstein-zz
Copy link

There is a fix checked into livestreamer for the livestream.com issue. If nobody else has fixed it, I might try to merge it in later.


From: skulblakka notifications@github.com
Sent: Monday, September 19, 2016 9:04:24 AM
To: streamlink/streamlink
Subject: Re: [streamlink/streamlink] Merge current most-up-to-date-livestreamer into streamlink (#9)

Twitch works fine. So does ustream (only tried the hls stream).

For livestream.com (using the akaimhd stream) I get 404 Client Error: Not Found for url: http://viewerplus.livestream.com/assets/swf/hdplayer-2.0-viewerplus.swf. The hls one works.

You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com//pull/9#issuecomment-247987161, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AESJ1oGQJG2E-hF6qvGP4seJwXMknXs5ks5qrohYgaJpZM4J__Kt.

@gravyboat
Copy link
Member

gravyboat commented Sep 19, 2016

@cdrage I'm fine with merging this in and agree with your point regarding it being messy. My main concern is that the primary sites still worked. As such I'm going to merge this.

Edit. I should note I did NOT squash on purpose so we can keep the history and properly credit these users.

@gravyboat gravyboat merged commit 9bc8949 into streamlink:master Sep 19, 2016
@gverm
Copy link
Contributor

gverm commented Sep 19, 2016

@gravyboat I opened a PR to fix azubu.tv

@gravyboat
Copy link
Member

@brainzyy I saw it, I'm going to have to let someone else review it for the time being as I'm not familiar enough with the codebase yet to review it confidently.

@gravyboat gravyboat mentioned this pull request Sep 19, 2016
@cdrage
Copy link
Contributor Author

cdrage commented Sep 19, 2016

@gravyboat thanks for the merge!

Alright. Now it's time to clean-up some of the code! xD I should have a few hours this week to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.