Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for goodgame.ru plugin #130

Merged
merged 1 commit into from
Nov 6, 2016
Merged

Conversation

beardypig
Copy link
Member

Patch to fix the goodgame.ru plugin courtesy of @intact, fixes #128

@codecov-io
Copy link

codecov-io commented Nov 6, 2016

Current coverage is 33.68% (diff: 100%)

Merging #130 into master will not change coverage

@@             master       #130   diff @@
==========================================
  Files            40         40          
  Lines          5349       5349          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           1802       1802          
  Misses         3547       3547          
  Partials          0          0          

Powered by Codecov. Last update 28d6737...ba0d8d6

@intact
Copy link
Contributor

intact commented Nov 6, 2016

@beardypig
Copy link
Member Author

That change was already in the plugin :)

@gravyboat
Copy link
Member

Thanks @beardypig.

@gravyboat gravyboat merged commit ec64ee2 into streamlink:master Nov 6, 2016
@beardypig beardypig deleted the fix-goodgame branch November 6, 2016 19:23
@flijloku
Copy link

flijloku commented Nov 6, 2016

@beardypig
@intact It is a pity that you have removed the part relating to the protection against DDoS. It helped to watch the stream when enabled protection from DDoS on the old site and may help in the future. Or I'm wrong?

@beardypig
Copy link
Member Author

@flijloku I just pulled the changes by @intact, perhaps @intact can answer your question.

@flijloku
Copy link

flijloku commented Nov 7, 2016

@beardypig chrippa/livestreamer#1518 (comment) - so I think @intact will not mind. I do not understand why it was removed from the plugin. It really works on the old site!

@beardypig beardypig restored the fix-goodgame branch November 7, 2016 10:13
@beardypig
Copy link
Member Author

@flijloku OK! I can add that back in.

@flijloku
Copy link

flijloku commented Nov 7, 2016

@beardypig Thank you! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Goodgame moved to the new version of the site
5 participants