testing: block inbound

was getting some disconnects, maybe this fixes it :c
stowmyy · Sep 1, 2024 · 075187c · 075187c
1 parent 264059c
commit 075187c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/dropship/src/FirewallManager.cpp b/dropship/src/FirewallManager.cpp
@@ -13,7 +13,8 @@
 
 bool FirewallManager::AddFirewallRule(Endpoint* e, bool enabled)
 {
-    return this->_windowsFirewall->add_rule(e, enabled, NET_FW_PROFILE2_ALL);
+    return this->_windowsFirewall->add_rule(e, NET_FW_RULE_DIR_OUT, enabled, NET_FW_PROFILE2_ALL)
+        && this->_windowsFirewall->add_rule(e, NET_FW_RULE_DIR_IN, enabled, NET_FW_PROFILE2_ALL);
 }
 
 
@@ -50,7 +51,8 @@ void FirewallManager::flushRules(std::vector<Endpoint>* endpoints)
     printf("Adding rules..\n");
     for (auto &e : *endpoints)
     {
-        this->_windowsFirewall->add_rule(&e, false);
+        this->_windowsFirewall->add_rule(&e, NET_FW_RULE_DIR_OUT, false);
+        this->_windowsFirewall->add_rule(&e, NET_FW_RULE_DIR_IN, false);
     }
     printf("Added %d rules.\n", endpoints->size());
 

diff --git a/dropship/src/_WindowsFirewallUtil.h b/dropship/src/_WindowsFirewallUtil.h
@@ -648,7 +648,7 @@ class _WindowsFirewallUtil : public failable
         }
 
         // returns true if succeeded
-        bool add_rule(Endpoint* e, bool enabled = false, NET_FW_PROFILE_TYPE2_ profile = NET_FW_PROFILE2_ALL)
+        bool add_rule(Endpoint* e, NET_FW_RULE_DIRECTION_ dir, bool enabled = false, NET_FW_PROFILE_TYPE2_ profile = NET_FW_PROFILE2_ALL)
         {
             //BSTR bstrRuleName = SysAllocString(std::wstring(e.title.begin(), e.title.end()).c_str());
             BSTR bstrRuleName = _com_util::ConvertStringToBSTR(e->title.c_str());
@@ -675,7 +675,7 @@ class _WindowsFirewallUtil : public failable
             //pFwRule->put_ApplicationName(bstrRuleApplication);
             pFwRule->put_Protocol(NET_FW_IP_PROTOCOL_ANY);
             pFwRule->put_RemoteAddresses(bstrRuleRAddresses);
-            pFwRule->put_Direction(NET_FW_RULE_DIR_OUT);
+            pFwRule->put_Direction(dir);
             pFwRule->put_Grouping(bstrRuleGroup);
             pFwRule->put_Profiles(profile);
             pFwRule->put_Action(NET_FW_ACTION_BLOCK);