feat!: content serve authorization #1590
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fforbeck
force-pushed
the
feat/gateway-authorization
branch
2 times, most recently
from
b98e723
to
5d8ba9b
Compare
2 tasks
alanshaw
requested changes
Nov 27, 2024
Peeja
requested changes
Nov 27, 2024
Peeja
previously requested changes
Nov 29, 2024
fforbeck
force-pushed
the
feat/gateway-authorization
branch
from
9984a07
to
7a395a9
Compare
alanshaw
requested changes
Nov 29, 2024
fforbeck
force-pushed
the
feat/gateway-authorization
branch
2 times, most recently
from
e0fb6fb
to
d533b7a
Compare
fforbeck
force-pushed
the
feat/gateway-authorization
branch
from
d533b7a
to
5f414b0
Compare
fforbeck
commented
Dec 2, 2024
| @@ -13,13 +13,15 @@ export const provide = (ctx) => | |||
|
|
|||
| /** | |||
| * Checks if the given Principal is an Account. | |||
| * | |||
fforbeck
commented
Dec 2, 2024
| * @param {API.Principal} principal | ||
| * @returns {principal is API.Principal<API.DID<'mailto'>>} | ||
| */ | ||
| const isAccount = (principal) => principal.did().startsWith('did:mailto:') | ||
|
|
||
| /** | ||
| * Returns true when the delegation has a `ucan:*` capability. | ||
| * |
fforbeck
commented
Dec 2, 2024
| * @param {Agent<S>} agent | ||
| * @param {Types.Invocation} invocation |
alanshaw
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
To enable a gateway to serve content from a specific space, we must ensure that the space owner delegates the
space/content/serve/*capability to the Gateway. This delegation allows the Gateway to serve content and log egress events appropriately.I created a new function
authorizeContentServefor this implementation and included it in thecreateSpaceflow. This is a breaking change because now the user is forced to provide the DIDs of the Content Serve services, and the connection, or skip the authorization flow.Additionally, with the
authorizeContentServefunction, we can implement a feature in the Console App that enables users to explicitly authorize the Freeway Gateway to serve content from existing/legacy spaces.Main Changes
authorizeContentServe, in thew3up-clientmodule to facilitate the delegation process. Integrated it with thecreatedSpaceflow.Issue: #158