Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: issue of internal and exterrnal links in article #2731

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

fix: issue of internal and exterrnal links in article #2731

wants to merge 7 commits into from

Conversation

SB-venkatyadavilli
Copy link
Contributor

@SB-venkatyadavilli SB-venkatyadavilli commented Oct 30, 2024 •
edited
Loading

Addressed

STOP-1073

Description

fixed the issue of Devportal Links between the article.

Testing

I have tested it manually and also tested in the platform-internal using Yalc.

Artifact

Before fix:

Screen.Recording.2024-10-30.at.4.31.22.PM.mov

After fix:

Screen.Recording.2024-10-30.at.4.27.52.PM.mov

@SB-venkatyadavilli SB-venkatyadavilli requested a review from a team as a code owner October 30, 2024 10:08
@netlify Netlify
Copy link

netlify bot commented Oct 30, 2024 •
edited
Loading

✅ Deploy Preview for stoplight-elements-demo ready!

Name Link
🔨 Latest commit 31f575c
🔍 Latest deploy log https://app.netlify.com/sites/stoplight-elements-demo/deploys/673f416583e6e70008e0f0ba
😎 Deploy Preview https://deploy-preview-2731--stoplight-elements-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Oct 30, 2024 •
edited
Loading

✅ Deploy Preview for stoplight-elements ready!

Name Link
🔨 Latest commit 31f575c
🔍 Latest deploy log https://app.netlify.com/sites/stoplight-elements/deploys/673f4165f50414000853f891
😎 Deploy Preview https://deploy-preview-2731--stoplight-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ben-smartbear
Copy link
Contributor

please add a test for this

prafullaAtSB
prafullaAtSB approved these changes Nov 8, 2024
View reviewed changes
Copy link

@prafullaAtSB prafullaAtSB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks ok to go ahead. Update the testing scenarios as a part of verification.

bhaskarsontakke
bhaskarsontakke approved these changes Nov 8, 2024
View reviewed changes
Copy link

@bhaskarsontakke bhaskarsontakke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good to me. Though, have added small suggestion. Please address it

@mnaumanali94 mnaumanali94 added the t/to-review To be reviewed by the team label Nov 8, 2024
@ben-smartbear
Copy link
Contributor

i don't see the requested unit test for this?

@SB-venkatyadavilli
Copy link
Contributor Author

i don't see the requested unit test for this?
development is in progress

@SB-venkatyadavilli SB-venkatyadavilli marked this pull request as draft November 13, 2024 07:39
@SB-venkatyadavilli SB-venkatyadavilli marked this pull request as ready for review November 21, 2024 13:37
@SB-venkatyadavilli
Copy link
Contributor Author

@ben-smartbear , have added Unit test case, can you please re-review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SB-akshaythakar SB-akshaythakar SB-akshaythakar approved these changes

@prafullaAtSB prafullaAtSB prafullaAtSB approved these changes

@ben-smartbear ben-smartbear ben-smartbear approved these changes

@bhaskarsontakke bhaskarsontakke bhaskarsontakke approved these changes

@bgriffn bgriffn Awaiting requested review from bgriffn bgriffn is a code owner automatically assigned from stoplightio/elements-owners

Assignees
No one assigned
Labels
t/to-review To be reviewed by the team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@SB-venkatyadavilli @ben-smartbear @bhaskarsontakke @prafullaAtSB @SB-akshaythakar @mnaumanali94