-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for matches being lost near the celestial poles #1
base: master
Are you sure you want to change the base?
Conversation
I have come to the realization that the Sort-Merge-Join speedup requires a single table column to appear in the range expression for matching. I've added an I think all problems can be solved by adding the |
f3cd375
to
d77cc66
Compare
967ffa6
to
31995c8
Compare
This PR fixes the drop in crossmatching density near the celestial poles by applying the cosine of Declination following astronomy-commons#22 and astronomy-commons#23.
The fix for overflowing histogram2d from astronomy-commons@56248a1 has been included here as I wanted to test a subset of the sky near the celestial poles.