re-enable linux arm64 builds #1060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graydon
force-pushed
the
arm64
branch
3 times, most recently
from
d0077bb
to
46b4ca0
Compare
graydon
force-pushed
the
arm64
branch
2 times, most recently
from
a273b16
to
d46255b
Compare
leighmcculloch
approved these changes
Aug 24, 2023
auto-merge was automatically disabled
August 25, 2023 19:48
Merge queue setting changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1011 by avoiding the use of
crate-type = ["cdylib"]in native builds.It was causing some linker errors when cross-compiling from x64-linux to aarch64-linux, I believe the root cause is rust-lang/cargo#4133 i.e. cargo failing to select the right target linker during cross builds.
The
cdylibcrate type is only relevant when building wasms, so this change just lowers that functionality into the specific commands that build wasms.