Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix auth test #1058

Closed
graydon opened this issue Aug 17, 2023 · 0 comments · Fixed by #1059
Closed

fix auth test #1058

graydon opened this issue Aug 17, 2023 · 0 comments · Fixed by #1059
Assignees
@dmkozh

Comments

@graydon
Copy link
Contributor

graydon commented Aug 17, 2023

rs-soroban-sdk/soroban-sdk/src/tests/token_client.rs

Line 45 in 9506a86

#[should_panic] // FIXME: this is not supposed to panic; it does due to auth failure, dmkoz to fix.

in #1057 a few calls to switch_to_recording_auth were given true arguments to adapt to changes upstream in env, and this caused a test to break. @dmkozh requested the test be disabled so that he could refactor it to accommodate. this bug is just a reminder about doing so.
@dmkozh dmkozh mentioned this issue Aug 18, 2023
Merged
dmkozh added a commit that referenced this issue Aug 22, 2023
@dmkozh @sisuresh
Provide a way to allow non-root auth in recording mode. (#1059)
d8bd392 
### What

Provide a way to allow non-root auth in recording mode.

This is intentionally done via a separate helper with lengthy name and
not a `mock_all_auths` argument - this is intended to be an option for a
few 'exotic' contracts that do non-atomic bundling and majority of the
users shouldn't ever need that.

Resolves #1058

### Why

Recording auth now doesn't allow non-root `require_auth` by default in
order to prevent the potential user footguns. This PR brings back the
old behavior where non-root auth is allowed.

### Known limitations

N/A

Co-authored-by: Siddharth Suresh <siddharth@stellar.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmkozh dmkozh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Provide a way to allow non-root auth in recording mode. dmkozh/rs-soroban-sdk
2 participants
@graydon @dmkozh