Provide a way to allow non-root auth in recording mode. #1059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is intentionally done via a separate helper with lengthy name and not a `mock_all_auths` argument - this is intended to be an option for a few 'exotic' contracts that do non-atomic bundling and majority of the users shouldn't ever need that.
sisuresh
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Provide a way to allow non-root auth in recording mode.
This is intentionally done via a separate helper with lengthy name and not a
mock_all_authsargument - this is intended to be an option for a few 'exotic' contracts that do non-atomic bundling and majority of the users shouldn't ever need that.Resolves #1058
Why
Recording auth now doesn't allow non-root
require_authby default in order to prevent the potential user footguns. This PR brings back the old behavior where non-root auth is allowed.Known limitations
N/A