Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ANCHOR-729]Include buy/sell delivery method in SEP-38 GET /quote response #1520

Merged

Conversation

JiahuiWho
Copy link
Contributor

@JiahuiWho JiahuiWho commented Sep 25, 2024

Description

Included in Sep38QuoteResponse which is returned by POST /quote and GET /quote
Also in GetQuoteResponse which is used when publish QUOTE_CREATED event

Testing

  • ./gradlew test

Documentation

stellar/stellar-protocol#1556

@JiahuiWho JiahuiWho marked this pull request as ready for review September 26, 2024 18:09
@lijamie98
Copy link
Collaborator

Can you add tests to the configuration and service classes?

Copy link
Collaborator

@lijamie98 lijamie98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JiahuiWho JiahuiWho merged commit 2fec92c into stellar:feature/v3 Sep 30, 2024
7 checks passed
@JiahuiWho JiahuiWho deleted the anchor-729-buy/sell-delivery-method branch September 30, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants