Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Multi-LD #240

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Conversation

abought
Copy link
Member

@abought abought commented Mar 16, 2021

Ticket

#213

Purpose

Allow users to request more than one LD reference variant within the same plot. This is useful for regions with more than one potentially independent signal.

This should also serve as a proof-of-concept for using widgets to encapsulate complex calculation logic, like visualization options that affect many fields at once, or legends that should rewrite their own definition to reflect the currently selected variants:

  • Layout rewrites (dynamically updating panel legends to show color schemes for 1..4 variants)
    • Should respect alternate layouts, eg if the display_options widget has overridden default behavior, then only rewrite legend when the legend is showing LD
  • Clearing old LD reference variants as user scrolls to a new region (region_changed event)
  • Tooltips should now show best-match ld variant, new add variant links etc

Summary of changes

  • Allow scalable parameters to request/receive more than one field in the same custom scaling function
  • Legends now support new "shape: ribbon" option describing LD palette
  • LDServer adapter now allows requesting more than one LDRefvar, and provides additional fields of info, eg which refvar is the best match
  • Allow scatter plots to configure stroke color (one value for all points)- move from SCSS to d3 root element
  • New toolbar button that encapsulates layer-layout rewrite logic when multiple ld refvars are selected
  • Identify best way to set multiple ld refvars

+ Start work on multi-LD extension feature
This removes the ability to handle a lot of poorly-documented variation that was never used, prior to adding new dynamic behavior for something else.
@abought abought added this to the v0.14.0 milestone Oct 6, 2021
@sir4ur0n sir4ur0n mentioned this pull request Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant