Better readme on static / dynamic definitons chapter #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
README.md
Outdated
| @@ -545,6 +545,10 @@ class Machine | |||
| def self.new(object, *args, &block) | |||
| machine_class = Class.new | |||
| machine = machine_class.state_machine(*args, &block) | |||
|
|
|||
| # this is the `attribute` which stores the value for state in the class | |||
| # exaple for the Vehicle it would be `state` reader | |||
There was a problem hiding this comment.
Sorry, I will correct it right away
ristovskiv
force-pushed
the
better_readme_for_dynamic_definition
branch
from
3fae95e
to
b36559d
Compare
| # This won't change the value of the `attribute` on the Vehicle class if it already | ||
| # has a value assigned to it. Otherwise it will set it to the initial one | ||
| state = object.send(attribute) | ||
| machine_class.new.tap{|machine| machine.send("#{attribute}=", state) if state} |
There was a problem hiding this comment.
Do we need to complicate the example that much? Why the previous example is not good?
There was a problem hiding this comment.
Ok I really don't know how I've missed this notification...I'm gonna reply back as soon as I get off from work. My apologies, really sorry.
|
Was useful to fix the problem with activerecord and dynamic state machine class (dynamic state machine class overrides activerecord object state to initial on each initialization). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code that was posted before changed the value of the state method in the Vehicle class to the initial one, no matter if it already has one or not.