[DRAFT] Calib uplift #772
Merged
[DRAFT] Calib uplift #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…prevalent" or "incident" as part of evaluating fit. Also need to perform an integration for incident parameters, in case times and observed times don't align.
This was referenced Nov 18, 2024
Closed
daniel-klein
commented
Nov 18, 2024
| logL += gln(real_data['x'] + sim_data['x'] + 1) + gln(real_data['n'] - real_data['x'] + sim_data['n'] - sim_data['x'] + 1) - gln(real_data['n'] + sim_data['n'] + 2) | ||
| logL += gln(sim_data['n'] + 2) - gln(sim_data['x'] + 1) - gln(sim_data['n'] - sim_data['x'] + 1) | ||
|
|
||
| def nll_beta(expected, actual): |
There was a problem hiding this comment.
should be beta binomial instead of just beta to avoid possible confusion, even if the name it longer
There was a problem hiding this comment.
Or maybe just binomial? Have added to #776
|
Nice improvements @cliffckerr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist