Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor calibration #776

Open
8 tasks
cliffckerr opened this issue Nov 18, 2024 · 0 comments
Open
8 tasks

Refactor calibration #776

cliffckerr opened this issue Nov 18, 2024 · 0 comments
Labels
highpriority High priority for collaborators refactor Code needs refactoring
Milestone

Comments

@cliffckerr
Copy link
Contributor

cliffckerr commented Nov 18, 2024

  • Ensure ss.Calibration().calibrate() works as easily as possible
  • Simplify build_sim
  • Update API to ensure consistency
  • Improve plotting (e.g. include data)
  • Simplify suggest_type
  • Reconsider names for beta/beta_binomial etc
  • Improve docstrings
  • Consider weighted interval score / energy scores

Consider moving this to check_fit():

    if calib.after_fits.mean() <= calib.before_fits.mean():
        print('✓ Calibration improved fit')
    else:
        print('✗ Calibration did not improve fit, but this sometimes happens stochastically and is not necessarily an error')
@cliffckerr cliffckerr added this to the Version 2.3 milestone Nov 18, 2024
@cliffckerr cliffckerr added the refactor Code needs refactoring label Nov 18, 2024
@cliffckerr cliffckerr mentioned this issue Nov 18, 2024
4 tasks
@cliffckerr cliffckerr added the highpriority High priority for collaborators label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
highpriority High priority for collaborators refactor Code needs refactoring
Projects
None yet
Development

No branches or pull requests

1 participant