-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add templates for light-year, decade and century #379
base: master
Are you sure you want to change the base?
Conversation
|
Also, last year/decade/century usually means "within the the last 1/10/100 years", so something like |
Not sure about your last comment. To me, "last year" means 2019, and "this year" means 2020. "Last year" is not the same as "in the last 12 months". "Last decade" and "last century" work the same: 2000-2010 and 1900-2000 resp. Also, before merging this patch, you will need to:
Also, what's the purpose for these units, other than "they are useful"? Is there a project that depends on these? |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still care about this? Let's rebase/merge if so?
This PR adds constant templates needed for three new measurement units added in stanford-oval/thingtalk-units#30 PR.