Frontend/#636 #638
Merged
Frontend/#636 #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you able to address the failed test?
|
|
@humansinstitute yeah! Just working on that won't be long 🚀 |
|
@humansinstitute fixed the tests on local will be reflected on checks shortly |
elraphty
reviewed
Nov 15, 2024
|
|
||
| try { | ||
| const ps2 = await api.get(query2); | ||
| const ps3: any[] = []; | ||
|
|
||
| if (ps2 && ps2.length) { | ||
| if (ps2) { |
There was a problem hiding this comment.
This should be a backend fix
|
@humansinstitute, I think this should be a backend fix, the filters are sent to the backend. |
|
@elraphty agreed need more data from back-end that would be much better |
|
But lot of current data coming from back-end is very messy so this might come in handy while backend issue is being fixed 🤔 |
|
@humansinstitute do you have any follow ups for me on this? Let me know Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
loom video
workspace
https://www.loom.com/share/e8cb4cdefbc84d37904664c1d118612a
##person bounties
https://www.loom.com/share/40e893e95b9a4d6fb304db9c2aeb13f4
bounties page
https://www.loom.com/share/843be30f66f5452b8771f0aee3e0271c
Describe your changes
consistency amongst filters
Issue ticket number and link
#636
Type of change
bug fixes for user experience
Please delete options that are not relevant.
Checklist before requesting a review