Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use bitcoin-connect for self-custodial zaps #715
Use bitcoin-connect for self-custodial zaps #715
Changes from all commits
8fb4957
cb4a40a
238d582
375d98b
ba05fbb
d9a79af
fcdb585
6d28b42
f1bf5dd
e06e862
59008b7
6ae3382
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you could import
init
here too and then call it to set Stacker News as the name of the connecting app (this will work for at least NWC and maybe other connectors in the future)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These functions are imported and then passed as state, could they just be imported where they are actually used? actually I don't think they are even used yet, are they?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am importing all of them here so I can simply use what I need where I need it by calling
useWebLN
. If I would import them where they are actually used, I would spreaduseEffect
with an async wrapper inside around our code base which is what I wanted to avoid. Simply callinguseContext
is a nicer syntax:pages/wallet.js:
You're right,
isConnected
isn't used outside of this function andlaunchPaymentModal
isn't used because of this but the other functions are. I anticipated that I would use these two functions at some point, too.