Feat: PDF support via Imgproxy #1637
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epubs can be converted to PDF via epub-parser. If support is still wanted we need to evaluate adding this library |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Completes #853.
These changes allows for PDFs to be uploaded and processed by Imgproxy. At the moment it retrieves the first page of an uploaded PDF to be displayed as a thumbnail, setting the quality, the color background and DPI per Imgproxy options.
Screenshots
n/a
Additional Context
This is an exclusive Imgproxy PRO feature, other than following the documentation, AFAIK there's no way for me to test this functionality. Therefore i'll draft this PR until we're sure it works.
The issue asked for total pdf to image conversion but then later for native upload (for long pdfs), should we convert all the pdf?
Checklist
Are your changes backwards compatible? Please answer below:
Being an addition with processing and detection happening only after image/video, it shouldn't affect existing uploads
On a scale of 1-10 how well and how have you QA'd this change and any features it might affect? Please answer below:
2.
For frontend changes: Tested on mobile, light and dark mode? Please answer below:
Color background for PDF is set to be white
Did you introduce any new environment variables? If so, call them out explicitly here: No