Fix: progress bar shown on back navigation through pathname check #1633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Progress bar is shown when navigating back in the history. Fixes #1471.
Videos
Current behaviour (master)
The progress bar is not showing in the upper-left corner while navigating back.
master.mp4
Proposed behaviour (this PR)
The progress bar is shown in the upper-left corner while navigating back if the pathname changes.
pr.mp4
Additional Context
The fix is based on checking, in case of shallow routing, if the pathname changes. If so, the progress bar is shown, otherwise it is not. I think this makes sense as we do not want to show progress bar if we are navigating in the same page. If this is not desired, instead, it would make sense to not check the 'shallow' value at all.
Checklist
Are your changes backwards compatible? Please answer below: Yes
On a scale of 1-10 how well and how have you QA'd this change and any features it might affect? Please answer below: 8, manual testing on both master and PR branch
For frontend changes: Tested on mobile, light and dark mode? Please answer below: Yes
Did you introduce any new environment variables? If so, call them out explicitly here: No