Show attached wallet balance #1602
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riccardobl
force-pushed
the
attachedbalance
branch
from
6cf8190
to
9ede708
Compare
There was a problem hiding this comment.
Copilot reviewed 5 out of 13 changed files in this pull request and generated no suggestions.
Files not reviewed (8)
- wallets/webln/client.js: Evaluated as low risk
- lib/format.js: Evaluated as low risk
- wallets/validate.js: Evaluated as low risk
- wallets/index.js: Evaluated as low risk
- components/accordian-item.js: Evaluated as low risk
- wallets/blink/common.js: Evaluated as low risk
- wallets/common.js: Evaluated as low risk
- wallets/lnbits/client.js: Evaluated as low risk
Comments skipped due to low confidence (1)
components/nav/common.js:16
- The abbrNum function is no longer imported in components/nav/common.js. Ensure that this change does not break any existing functionality.
import { abbrNum, msatsToSats } from '../../lib/format'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When you create a send+receive isolated account for sn on an lnbits or AlbyHub instance, the user experience is almost the same to using the custodial sn wallet, with one minor drawback: you can't easily see your balance from the sn UI.
It's not ideal to have to blindly zap or switch apps just to check how many sats you've accumulated or have left. This PR addresses that issue by adding a feature to fetch and display the balance from all attached wallets directly in the sn interface.
The ideal setup has using a single send+receive attachment, though multiple attachments are also supported. The system displays the balance of the attachment with the highest number of sats, appending a '+' if additional sats are present in other attachments. A detailed summary of all attachments can be viewed by hovering over the balance. Note that the custodial balance is treated as a separate wallet.
Screenshots
With one non-zero balance
with more than one non-zero balance
Tests
Checklist
Are your changes backwards compatible? Please answer below:
On a scale of 1-10 how well and how have you QA'd this change and any features it might affect? Please answer below:
For frontend changes: Tested on mobile, light and dark mode? Please answer below:
Did you introduce any new environment variables? If so, call them out explicitly here: