Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete fix of 5.4 Reshare Denial-of-Service via Predicable Instance IDs #162

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

pavelkrolevets
Copy link
Contributor

  • compute instance ID at operators as `[24]byte = [8]byte(keccak(initiator pub)) + [8]byte(keccak(message)) + [8]byte(uuid entropy)

This effectively prevents malicious actors to create same instance IDs at operators for DoS as [8]byte of keccak(initiator pub) ensures that only initiator can use one unique ID as we verify his signature and ensure that pub key belongs to initiator.

Copy link
Contributor

@MatusKysel MatusKysel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MatusKysel MatusKysel merged commit a00890a into unstable Nov 19, 2024
1 check passed
@MatusKysel MatusKysel deleted the complete-fix-of-5.4 branch November 19, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants