Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for 5.10 reshare denial of service via predicable instance ids #152

Merged

Conversation

pavelkrolevets
Copy link
Contributor

Description:

A reshare message can initiate multiple DKG instances. The request IDs for those DKG instances are
chosen deterministically by hashing the reshare message. Then, the DKG instances are performed by
the initiator in sequence. Given that instances become stale after one minute, it is possible to evict later
reshare instances from the buffer by reuse their instance ID or spamming the buffer. This will prevent the
legitimate initiator from finishing.

Solution:

  • add entropy to instance ID by combining 12 bytes of random UUID and hash of reshare message.

@pavelkrolevets pavelkrolevets changed the title Fix for 5.10 reshare denial of service via predicable instance i ds Fix for 5.10 reshare denial of service via predicable instance ids Nov 6, 2024
@MatusKysel MatusKysel merged commit abbc1fa into unstable Nov 11, 2024
1 check passed
@MatusKysel MatusKysel deleted the 5.10-Reshare-Denial-of-Service-via-Predicable-Instance-IDs branch November 11, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants