Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix audit issue 5.3 Crash by Malicious Operator #150

Merged
merged 3 commits into from
Nov 7, 2024

Conversation

pavelkrolevets
Copy link
Contributor

Description:
When processing a message of type ReshareExchangeMessageType from another operator relayed
by the initiator, the operator dereferences the DKGData.reshare field to access the list of new
operators. These types of messages are only expected during reshare DKG and not during the initial
DKG. As a consequence, a malicious operator could intentionally submit an reshare message. This
would cause other operators to dereference a nil pointer and crash.

Solution:

  • add checks that objects DKGData.reshare or DKGData.reshare not nil when processing messages.

@MatusKysel MatusKysel merged commit baeb031 into unstable Nov 7, 2024
1 check passed
@MatusKysel MatusKysel deleted the 5.3-Crash-by-Malicious-Operator branch November 18, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants