Fix audit issue 5.3 Crash by Malicious Operator #150
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When processing a message of type ReshareExchangeMessageType from another operator relayed
by the initiator, the operator dereferences the DKGData.reshare field to access the list of new
operators. These types of messages are only expected during reshare DKG and not during the initial
DKG. As a consequence, a malicious operator could intentionally submit an reshare message. This
would cause other operators to dereference a nil pointer and crash.
Solution:
DKGData.reshare
orDKGData.reshare
notnil
when processing messages.