Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit fix: Insecure TLS Default Configuration #147

Merged
merged 4 commits into from
Oct 25, 2024
Merged

Audit fix: Insecure TLS Default Configuration #147

merged 4 commits into from
Oct 25, 2024

Conversation

pavelkrolevets
Copy link
Contributor

@pavelkrolevets pavelkrolevets commented Oct 23, 2024 •
edited
Loading

@pavelkrolevets pavelkrolevets marked this pull request as ready for review October 24, 2024 14:39
MatusKysel
MatusKysel requested changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@MatusKysel MatusKysel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove bind_*flags from file names. it is clear enough like this cli/flags/healthcheck.go IMO and it's easier to navigate. Also please add new flag to README, thanks

@MatusKysel MatusKysel merged commit 1a56594 into unstable Oct 25, 2024
1 check passed
@MatusKysel MatusKysel deleted the audit_tls_fix branch October 25, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatusKysel MatusKysel MatusKysel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pavelkrolevets @MatusKysel