Access properties of the window object using "^" #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"^localStorage" => "window.localStorage"
sstur
reviewed
Jan 7, 2020
| @@ -434,7 +434,7 @@ var jinja; | |||
| var get = function() { | |||
| var val, n = arguments[0], c = stack.length; | |||
| while (c--) { | |||
| val = stack[c][n]; | |||
| val = (n[0] == '^' ? window[n.slice(1)] : stack[c][n]); | |||
There was a problem hiding this comment.
I don't think it's safe to assume that window exists. An example where window does not exist is when running in Node. I think we will need a better way to do window[n.slice(1)] part, perhaps a helper function getGlobal(n.slice(1)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"^localStorage" => "window.localStorage"