add API to write peripheral register of target system #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems fine. Would you mind adding the 8-bit, 16-bit and 64-bit versions as well, alongside tests? |
|
I will try. |
|
Tested on NUC472HI8AE:all NVIC registers can be accessed using byte, halfword, and word.with these API, can direct control onboard devices(e.g. LED, buzzer). |
hkpeprah
reviewed
Feb 22, 2019
|
Just a single comment, otherwise looks good. Sorry about taking so long to get back to you on this. |
|
Before we can merge this, we'll need you to sign our CLA. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on NUC472HI8AE。