Various updates to address recently raised issues #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `.vscode` to `.gitignore` to prevent it from accidentally being added.
philwebb
force-pushed
the
updates
branch
5 times, most recently
from
cf5711e
to
17c4a0a
Compare
Update `asciidocExtensionRegistered.js` so that the resolve call doesn't pass a path. This allows the the function to work when running `gulp preview`. Fixes spring-io#200
The current file is hard to modify so this scrip allows us to recreate it easily using just the icon names. Closes #
Update the font-awesome CSS by using the version provided by https://gitlab.com/antora/antora-ui-default/-/merge_requests/121 which does not clash with admon CSS. Fixes spring-io#202
Update the list of highlight.js languages to include 'http' which is used by Spring Restdocs generated content. Closes spring-io#204
Refactor existing CSS to build on top of antora-default-ui CSS. This update allows us to apply our CSS tweaks on top of the standard Antora UI which should help us keep it in sync. In addition, the updated CSS provides the following changes: - Admon block styling has been updated to improve the look - Reduced contrast is now used for the dark theme - Callout formatting has been improved - The breadcrumb area has been moved to allow the main <article> tag to have the `doc` class applied. Without this change the default Antora CSS does not apply correctly. - Anchor hover positions have been improved. - Toolbox and Tab buttons have hover colors. - Tables can scroll horizontally when there is unbreakable content. - Spring specific css is prefixed with `spring-` to make the files easier to find from browser devtools. - Page bounce has been disabled Closes spring-io#205
Update CSS to use system fonts for body and heading. Closes spring-io#115
oodamien
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a number of commits to address recently raised issue. Since some fixes build on others it's hard to send individual PRs.