This repository has been archived by the owner on Nov 20, 2024. It is now read-only.
Generic error handling #85
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viniciusccarvalho
requested review from
garyrussell,
sobychacko and
artembilan
artembilan
suggested changes
Aug 10, 2017
| cause.printStackTrace(printWriter); | ||
| return stringWriter.getBuffer().toString(); | ||
| RabbitMessageChannelErrorConfigurer getErrorConfigurer(){ | ||
| return (RabbitMessageChannelErrorConfigurer) this.errorConfigurer; |
There was a problem hiding this comment.
I think we should be more strict here and require definitely only RabbitMessageChannelErrorConfigurer injection - no any generic BinderErrorConfigurer support.
More over you are going to catch here ClassCast if you don't provide exactly RabbitMessageChannelErrorConfigurer.
| @@ -0,0 +1,163 @@ | |||
| package org.springframework.cloud.stream.binder.rabbit; | |||
There was a problem hiding this comment.
Copyright is missed. Again the Checkstyle responsibility.
I don't tell to do that right now, but our code is getting dirtier and dirtier...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #84
Make sure you have pulled the changes from spring-cloud/spring-cloud-stream#1038 before