Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDKS-7838 Show Cached flag sets #261

Merged
merged 11 commits into from
Jan 11, 2024
Merged

Conversation

sanzmauro
Copy link
Contributor

@sanzmauro sanzmauro commented Dec 21, 2023

Split Synchronizer

What did you accomplish?

  • Cached Flag Sets
Screenshot 2023-12-21 at 10 39 54
  • New Flag Sets Tab
Screenshot 2023-12-21 at 10 39 43
  • Endpoint: /admin/dashboard/stats
➜  ~ curl GET http://localhost:3010/admin/dashboard/stats -H "Accept: application/json" 
curl: (6) Could not resolve host: GET
{"backendTotalRequests":2,"requestsOk":0,"requestsErrored":0,"backendRequestsOk":2,"backendRequestsErrored":0,"sdksTotalRequests":0,"loggedErrors":0,"loggedMessages":[],"featureFlags":[{"name":"LA_SCALONETA","active":true,"killed":false,"defaultTreatment":"Julian","treatments":["lautaro","Julian"],"flagSets":["set_all","set_sdk_team"],"cn":"Thu Dec 21 18:25:30 UTC 2023","changeNumber":1703183130195},{"name":"js-test","active":true,"killed":false,"defaultTreatment":"off","treatments":["on","off"],"flagSets":["set_all","set_backend","set_ui"],"cn":"Fri Oct 27 15:07:17 UTC 2023","changeNumber":1698419237485},{"name":"MESSI","active":true,"killed":false,"defaultTreatment":"PSG","treatments":["BCN","MLS","PSG","ARG"],"flagSets":["set_sdk_team","set_test"],"cn":"Thu Nov 30 17:35:43 UTC 2023","changeNumber":1701365743928},{"name":"FF_WITHOUT_SETS","active":true,"killed":false,"defaultTreatment":"off","treatments":["on","off"],"flagSets":[],"cn":"Fri Oct 27 15:07:46 UTC 2023","changeNumber":1698419266137},{"name":"DI_MARIA","active":true,"killed":false,"defaultTreatment":"off","treatments":["on","off"],"flagSets":["set_all","set_test"],"cn":"Wed Nov 29 17:41:22 UTC 2023","changeNumber":1701279682788},{"name":"nadia-test","active":true,"killed":false,"defaultTreatment":"off","treatments":["on","off"],"flagSets":["set_test"],"cn":"Tue Nov 28 13:33:35 UTC 2023","changeNumber":1701178415884},{"name":"python-test","active":true,"killed":false,"defaultTreatment":"off","treatments":["on","off"],"flagSets":["set_all","set_backend","set_ui"],"cn":"Fri Oct 27 15:07:25 UTC 2023","changeNumber":1698419245179},{"name":"android-test","active":true,"killed":false,"defaultTreatment":"off","treatments":["off","on"],"flagSets":["set_all","set_backend","set_ui"],"cn":"Fri Oct 27 15:06:49 UTC 2023","changeNumber":1698419209246},{"name":"ios-test","active":true,"killed":false,"defaultTreatment":"off","treatments":["on","off"],"flagSets":["set_all"],"cn":"Thu Nov 30 16:40:03 UTC 2023","changeNumber":1701362403497},{"name":"java-test","active":true,"killed":false,"defaultTreatment":"off","treatments":["on","off"],"flagSets":["set_all","set_backend","set_ui"],"cn":"Fri Oct 27 15:07:08 UTC 2023","changeNumber":1698419228779},{"name":"MAURO-TEST","active":true,"killed":false,"defaultTreatment":"v1","treatments":["v1","v2","v3"],"flagSets":["set_all","set_sdk_team","set_test"],"cn":"Wed Nov 15 15:45:42 UTC 2023","changeNumber":1700063142312}],"segments":[],"latencies":null,"backendLatencies":[{"label":"/api/splitChanges","data":[0,0,0,0,0,0,0,0,0,0,2,0,0,0,0,0,0,0,0,0,0,0,0],"backgroundColor":"rgba(255, 159, 64, 0.20)","borderColor":"rgba(255, 159, 64, 1.00)","borderWidth":1},{"label":"/api/segmentChanges","data":[0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0],"backgroundColor":"rgba(54, 162, 235, 0.20)","borderColor":"rgba(54, 162, 235, 1.00)","borderWidth":1},{"label":"/api/testImpressions/bulk","data":[0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0],"backgroundColor":"rgba(75, 192, 192, 0.20)","borderColor":"rgba(75, 192, 192, 1.00)","borderWidth":1},{"label":"/api/events/bulk","data":[0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0],"backgroundColor":"rgba(255, 205, 86, 0.20)","borderColor":"rgba(255, 205, 86, 1.00)","borderWidth":1}],"impressionsQueueSize":0,"impressionsLambda":1,"eventsQueueSize":0,"eventsLambda":1,"uptime":29,"flagSets":[{"name":"set_all","featureFlagsAssociated":8,"featureFlags":"LA_SCALONETA, ios-test, java-test, ......~ 
  • Endpoint: /admin/observability
~ curl GET http://localhost:3010/admin/observability
curl: (6) Could not resolve host: GET
{"activeFlagSets":["set_backend","set_test","set_all","set_sdk_team","set_ui"],"activeSegments":{},"activeSplits":["js-test","MESSI","DI_MARIA","nadia-test","python-test","ios-test","java-test","LA_SCALONETA","android-test","MAURO-TEST","FF_WITHOUT_SETS"]}%  

@sanzmauro sanzmauro self-assigned this Dec 21, 2023
@sanzmauro sanzmauro requested a review from a team as a code owner December 21, 2023 13:44
mmelograno
mmelograno previously approved these changes Jan 2, 2024
@mmelograno
Copy link
Contributor

You should also include the flagsets on the API stats that Sync has. as well as adding unit test

@sanzmauro sanzmauro changed the base branch from master to release-5.6.0 January 11, 2024 19:04
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition 57.1% 57.1% Coverage on New Code (is less than 80%)

See analysis details on SonarQube

@sanzmauro sanzmauro merged commit 7324197 into release-5.6.0 Jan 11, 2024
5 of 6 checks passed
@sanzmauro sanzmauro deleted the SDKS-7838-cached-flag-sets branch January 11, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants