Fix: Toggling between different namespaces crashes the viewer #35
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a simple variable name change that fixes the below error that occurs whenever we try to switch between various namespaces in the viewer. This is a common scenario when we have multiple trees running. The viewer will always crash when we try to toggle between these trees.
The error:
On further examination, it looks like
snapshot_stream_watcher
is referenced only in this particular line. The same function proceeds to assign a new snapshot to the variableself.snapshot_stream
. This must have been missed out in a refactor.Hope this helps!
Thank you @stonier for building and maintaining py_trees and all its associated tools & libraries!