Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Behaviors to Interact with ROS Services #215

Merged

Conversation

amalnanavati
Copy link
Contributor

This PR implements service clients as behaviors. Following the paradigm for action clients, it implements two behaviors: FromBlackboard, which reads the request from the blackboard, and FromConstant, which always has the same request. Additionally, it has the option to write the service response to the blackboard, by passing in a blackboard key (key_response) to write to.

This has been tested on a number of test cases (see test_service_client.py). The code has not been through any formatter since I wasn't sure which is used for this repository.

I believe this fulfills Issue #103 .

@amalnanavati
Copy link
Contributor Author

BTW, this is ready for review :)

Copy link
Collaborator

@sea-bass sea-bass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @amalnanavati -- I'm just starting to take a look at this repo after recently agreeing to help out with it.

Honestly, I looked through the code and it looks spotless. Thank you!

@sea-bass sea-bass merged commit 1729e28 into splintered-reality:devel Aug 31, 2024
@amalnanavati
Copy link
Contributor Author

Thank you, and thank you for agreeing to help out with this repo!

The only other thing I could see adding is a callback_group parameter, a la #220 . I created an issue for it (#225 ), for us to address whenever we have a chance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants