Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[subscribers] stricter arg handling #104

Merged
merged 3 commits into from
Sep 18, 2019
Merged

[subscribers] stricter arg handling #104

merged 3 commits into from
Sep 18, 2019

Conversation

stonier
Copy link
Member

@stonier stonier commented Sep 17, 2019 •
edited
Loading

Require users to provide, especially, ros comms arguments given that
there are more things that can go wrong in ros2 by blindly setting
best effort guesses.

FYI @peterpena

@stonier stonier added this to the 1.2 - Dashing milestone Sep 17, 2019
@stonier stonier self-assigned this Sep 17, 2019
@stonier
[subscribers] stricter arg handling
e32abbf 
Require users to provide, especially, ros comms arguments given that
there are more things that can go wrong in ros2 by blindly setting
best effort guesses.
@stonier
Copy link
Member Author

stonier commented Sep 18, 2019

See errors from an as not yet deployed py_trees package in CI. These changes are not slated for dashing - we'll get the build jobs going green for eloquent.

@stonier stonier merged commit a69289d into devel Sep 18, 2019
@stonier stonier deleted the stonier/make_users_think branch September 18, 2019 16:58
@stonier stonier mentioned this pull request Sep 18, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@stonier stonier

Labels
component:behaviours type:enhancement
Projects
None yet
Milestone
1.2 - Dashing
Development

Successfully merging this pull request may close these issues.

[subscribers] force the user to provide a qos profile
1 participant
@stonier