Skip to content

Commit

Permalink
fix(proxy): Take advantage of InsecureOkHttpClientBuilderProvider (#…
Browse files Browse the repository at this point in the history
…1336)

The `DefaultOkHttpClientBuilderProvider` (previous behavior) will actually
utilize the `okHttpClient.*` config properties and unnecessarily set
keystore/truststores.

This is fine when communicating with other Spinnaker services but problematic
externally. The `InsecureOkHttpClientBuilderProvider` loosens the certificate
chain validations.
  • Loading branch information
ajordens authored Sep 11, 2020
1 parent 657fa35 commit 0168e53
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ internal class Proxy(val config: ProxyConfig) {
*/
fun init(okHttpClientProvider: OkHttpClientProvider) : Proxy {
val okHttpClient = okHttpClientProvider.getClient(DefaultServiceEndpoint(
"proxy__${config.id}", config.uri, config.additionalAttributes
"proxy__${config.id}", config.uri, config.additionalAttributes, false
))

this.okHttpClient = okHttpClient
Expand Down

0 comments on commit 0168e53

Please sign in to comment.