Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor database names/DB editor window and tab management #2997

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

soininen
Copy link
Contributor

@soininen soininen commented Nov 1, 2024

This PR centralizes the management of database codenames (dropping the term 'codename') and moves the management of DB editor windows/tabs from DB manager to a dedicated machinery. This does not yet make the system perfect, but paves way for more sane DB editor tab naming and behavior. It fixes some current issues and problems, though.

No associated issue.

Checklist before merging

  • Documentation is up-to-date
  • Release notes have been updated
  • Unit tests have been added/updated accordingly
  • Code has been formatted by black & isort
  • Unit tests pass

@soininen soininen force-pushed the drop_codenames branch 3 times, most recently from e85ae72 to 26ab292 Compare November 1, 2024 13:45
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 75.08772% with 71 lines in your changes missing coverage. Please review.

Project coverage is 67.12%. Comparing base (18814fa) to head (26ab292).

Files with missing lines Patch % Lines
...x/spine_db_editor/widgets/multi_spine_db_editor.py 65.71% 3 Missing and 9 partials ⚠️
...toolbox/spine_db_editor/widgets/spine_db_editor.py 71.79% 10 Missing and 1 partial ⚠️
...ox/spine_db_editor/mvcmodels/pivot_table_models.py 50.00% 7 Missing and 1 partial ⚠️
...olbox/spine_db_editor/widgets/add_items_dialogs.py 55.55% 8 Missing ⚠️
...oolbox/spine_db_editor/widgets/custom_delegates.py 0.00% 6 Missing ⚠️
...toolbox/spine_db_editor/widgets/custom_qwidgets.py 40.00% 3 Missing ⚠️
..._db_editor/widgets/edit_or_remove_items_dialogs.py 72.72% 3 Missing ⚠️
...ox/spine_db_editor/widgets/manage_items_dialogs.py 0.00% 3 Missing ⚠️
spinetoolbox/database_display_names.py 95.83% 1 Missing and 1 partial ⚠️
spinetoolbox/plotting.py 33.33% 2 Missing ⚠️
... and 8 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2997      +/-   ##
==========================================
+ Coverage   66.99%   67.12%   +0.13%     
==========================================
  Files         190      193       +3     
  Lines       37084    37102      +18     
  Branches     4447     4445       -2     
==========================================
+ Hits        24845    24906      +61     
+ Misses      10978    10931      -47     
- Partials     1261     1265       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Drop database codenames in favor of specific database display name
registry that centralizes all database name handling. This makes
it clearer who is responsible of giving names to DB editor tabs.
Also, moved DB editor window/tab management out of DB manager where
it arguable doesn't belong.
@soininen soininen merged commit 59a0d4e into master Nov 1, 2024
16 checks passed
@soininen soininen deleted the drop_codenames branch November 1, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant