Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent potential issues with undoing/redoing changes to loop conditions #2926

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

soininen
Copy link
Contributor

@soininen soininen commented Sep 3, 2024

A small fix potentially preventing a bug.

Re #2925

Checklist before merging

  • Documentation is up-to-date
  • Release notes have been updated
  • Unit tests have been added/updated accordingly
  • Code has been formatted by black & isort
  • Unit tests pass

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 66.86%. Comparing base (47a949f) to head (56e774d).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
spinetoolbox/project_commands.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2926      +/-   ##
==========================================
+ Coverage   66.85%   66.86%   +0.01%     
==========================================
  Files         190      190              
  Lines       37027    37027              
  Branches     6355     6355              
==========================================
+ Hits        24755    24759       +4     
+ Misses      10951    10945       -6     
- Partials     1321     1323       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soininen soininen merged commit 27d5f5d into master Sep 4, 2024
21 of 22 checks passed
@soininen soininen deleted the 2925_fix_loops branch September 4, 2024 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant