Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace os.curdir with __file__ #2278

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Replace os.curdir with __file__ #2278

merged 1 commit into from
Aug 25, 2023

Conversation

ptsavol
Copy link
Member

@ptsavol ptsavol commented Aug 25, 2023

This PR replaces os.curdir with __file__

Fixes #2274

Checklist before merging

  • Documentation is up-to-date
  • Release notes have been updated
  • Unit tests have been added/updated accordingly
  • Code has been formatted by black
  • Unit tests pass

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.03% ⚠️

Comparison is base (7632511) 64.13% compared to head (72669e2) 64.11%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2278      +/-   ##
==========================================
- Coverage   64.13%   64.11%   -0.03%     
==========================================
  Files         197      197              
  Lines       35821    35821              
  Branches     6124     6124              
==========================================
- Hits        22973    22965       -8     
- Misses      11618    11625       +7     
- Partials     1230     1231       +1     

see 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ptsavol ptsavol merged commit e4801cb into master Aug 25, 2023
16 checks passed
@ptsavol ptsavol deleted the 2274_replace_os_curdir branch August 25, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get rid of os.curdir in unit tests
2 participants