Feature/add no addr reads #22
Conversation
…on and CircuitPython drivers
…atibility with drivers that use that function from linux_i2c.py
| :return: response of read transaction | ||
| :rtype: list | ||
| """ | ||
| self._i2cbus.readBlock(address, write_message, read_nbytes) |
There was a problem hiding this comment.
This does not work in CircuitPython
| # Custom method for reading +8-bit register using `i2c_msg` from `smbus2` | ||
| # | ||
| # Designed to have same operation as the __i2c_rdwr method in linux_i2c.py | ||
| def __i2c_rdwr__(self, address, write_message, read_nbytes): |
There was a problem hiding this comment.
This method should be changed. I know this is what was used elsewhere, but it's not a great name. Should match the conventions of the other methods in this driver, and get added to i2c_driver.py and linux_i2c.py. Then any device drivers that use it (I think just the VL53?) should be changed to use this new method. Does that make sense?
There was a problem hiding this comment.
The naming convention was based off the original i2c_rdwr() method from the smbus2 Python package that this package utilizes as the driver on Linux platforms:
def i2c_rdwr(self, *i2c_msgs):
When we added this method, I included the double underscores (__) to give it a private attribute. This keeps the method hidden (in a way), since we were only using it for the VL53L1x. Additionally, the method wasn't considered a feature of the package, as noted in the README.md file of the smbus2 GitHub repository, :
Note
Starting with v0.2, the smbus2 library also has support for combined read and write transactions. i2c_rdwr is not really a SMBus feature but comes in handy when the master needs to:
- read or write bulks of data larger than SMBus' 32 bytes limit.
- write some data and then read from the slave with a repeated start and no stop bit between.
Each operation is represented by a i2c_msg message object.
As a recommendation... I'd keep the __i2c_rdwr__()method for backwards compatibility. Since it is technically private, we could create a new public method with the naming convention that you prefer. To keep the functionality, you could:
- Call on the
__i2c_rdwr__()method - Reuse the same code
No description provided.