Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#756 Refactor: map like list bankName2Code refactored to Map #755

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

xMHW
Copy link

@xMHW xMHW commented Mar 12, 2024

Summary

It closes #756
스크린샷 2024-03-12 오후 10 11 18
Use Map prototype explicitly. Avoid defining map as array.
Also, use Map.get() function rather Array.find() function in these similar scenarios.

Copy link

netlify bot commented Mar 12, 2024

Deploy Preview for taxi-dev-preview ready!

Name Link
🔨 Latest commit bded710
🔍 Latest deploy log https://app.netlify.com/sites/taxi-dev-preview/deploys/65f0551ebe98d800085a3e1c
😎 Deploy Preview https://deploy-preview-755--taxi-dev-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@xMHW xMHW changed the title Refactor: map like list bankName2Code refactored to Map #756 Refactor: map like list bankName2Code refactored to Map Mar 12, 2024
Copy link
Member

@kmc7468 kmc7468 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 코드가 더 깔끔해졌네요!

@xMHW xMHW requested a review from predict-woo March 12, 2024 17:07
Copy link
Member

@14KGun 14KGun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Map Refactor
3 participants