#541 24-chuseok event ban middleware #544
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
kmc7468
requested changes
Sep 7, 2024
| error: "eventValidator: internal server error", | ||
| }); | ||
| } | ||
| next(); |
src/lottery/modules/contracts.js
Outdated
| @@ -109,8 +109,8 @@ const quests = buildQuests({ | |||
| * @returns {Promise} | |||
| * @usage lottery/globalState - createUserGlobalStateHandler | |||
| */ | |||
| const completeFirstLoginQuest = async (userId, timestamp) => { | |||
| return await completeQuest(userId, timestamp, quests.firstLogin); | |||
| const completeFirstLoginQuest = async (req, userId, timestamp) => { | |||
There was a problem hiding this comment.
req에 이미 userOid가 포함되어 있어서, req를 받을거라면 userId 매개변수는 필요하지 않을 것 같습니다. (주석도 업데이트 부탁드려요)
There was a problem hiding this comment.
저희 quest 중에서 invitor의 userOid를 받아서 처리해야하는 부분이 있는데, req에는 아마 client의 userOid 값만 있어서 구분을 위해서는 userId parameter가 필요해보여요!
- src/lottery/services/globalState.js [line: 136--147]
| */ | ||
| const eventValidator = async (req, res, next) => { | ||
| try { | ||
| const eventStatus = await eventStatusModel |
There was a problem hiding this comment.
개인적으로는 이렇게 eventStatus를 가져오는 미들웨어보다는 필요한 services에서만 가져다 쓰는게 좋을 것 같다고 생각해요. 기존 코드에 user를 가져오는 미들웨어가 없고 필요한 services에서 직접 조회해서 쓰는 것처럼요. 물론 성능 차이는 거의 없겠지만, service에 따라 eventStatus를 단순히 조회만 하는 경우가 있고, 수정해야 하는 경우도 있는데 후자의 경우에는 (미들웨어가 있으면) query가 2번 발생하게 됩니다.
There was a problem hiding this comment.
계속 사용하는 것으로 결정
TaehyeonPark
changed the title
…541-24-chuseok-event-ban-middleware
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It closes #541