Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#524 접수된 신고 당사자에 FCM 발송 #525

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

xMHW
Copy link
Contributor

@xMHW xMHW commented May 28, 2024

Summary

It closes #524

접수된 신고의 당사자에게 FCM을 발송합니다.

  • Frontend에 Link("mypage?report=true")를 먼저 추가한 후에 머지

@xMHW xMHW requested review from kmc7468 and chlehdwon May 28, 2024 15:02
@kmc7468
Copy link
Member

kmc7468 commented May 29, 2024

query parameter보다는, 아예 홈 페이지처럼 endpoint?를 추가하는 방향으로 가면 어떨까요? /mypage/report 같은 느낌으로...

image

Copy link
Member

@kmc7468 kmc7468 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 빠른 작업 감사합니다~~~

await sendMessageByTokens(
await getTokensOfUsers([req.userId]),
"신고가 접수되었습니다.",
"신고 내용을 확인해주세요.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

미정산 / 미탑승 / 기타 정도의 신고 사유는 알림 메세지에서 바로 확인할 수 있어도 좋을 것 같습니다!

@@ -201,7 +200,7 @@ const sendMessageByTokens = async (tokens, type, title, body, icon, link) => {
},
apns: { payload: { aps: { alert: { title, body } } } },
android: {
ttl: 0,
ttl: 3600,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Report FCM Notification
2 participants